[SUBMISSION] Fire Aura Sphere

Info
Name: Fire Aura Sphere
Type: Damage Aura
Palette: Doom
Summon: FireAuraSphere
Use type: Instant
Duration: Instant
Brightmaps: No
Actor modification: No
ACS: No

Description:
Gives the player a fiery aura that deals medium damage to all monsters within its radius and eventually incinerates them. Corpses will be burned to ashes as well. Most effective against large mobs.

Credits
Code: DeVloek
GLDEFS: DeVloek
Sounds: id Software, GSC Game World
Sprites: id Software
Sprite Edit: DeVloek
Idea base: Elemental damage auras from Grim Dawn

Sprite Preview


Download
https://drive.google.com/file/d/1eXR4fdfu6pNYPLvYOx0LZL59SodgPWFY/view?usp=sharing


edit: fixed editor keys.

Also here's a pk3 that includes all auras (Fire, Frost, Electric). Let me know which submission method is preferable, seperate or all in one pack.
https://drive.google.com/file/d/1nx3kxHynRvL9R6a9H9Nw8J-1GcaOeLQj/view?usp=sharing

This and all the other spheres look amazing.
There's an issue with monsters with special functions in their death states (boss monsters, commander keens) not executing them when they burn into ashes.
Also you should add the fire sprites in the pk3 so they could be used in other games besides Doom 2.

Updated the file with the following changes:

- added fire sprites
- added A_Bossdeath and A_KeenDie to the burn death function so their special actions will be executed

A_Bossdeath was an easy fix since I can just check for bBoss and bBossDeath, but Commander Keen doesn't have anything like that so I had to check for his class itself.
That means, if a mod adds a monster that uses A_KeenDie but does not inherit from the CommanderKeen class, the modder has to add the monster's class to the line in my code that does the check. Otherwise the special door open action won't execute. I added this info as a comment in my code as well.
I don't know if there's a better way, CommanderKeen is a special case. Ice deaths have the same issue, I guess that's why the Zdoom devs gave the NOICEDEATH flag to Keen and some other actors.

There are seriously impressive, nice work

Do you think you could give an exception to monsters with the +NOICEDEATH? Some more complex bosses like D'sparil, Korax and the Strife bosses use this flag because they call special functions when they die, and they don't execute when they go through special state changes.

Hm that would also solve the CommanderKeen issue. I'll see what I can do about that.

Updated the file with the following changes:

- added a NOICEDEATH check for better boss compatibility
- removed code that handles CommanderKeen since he is now covered by the above check
- tweaked some dynamic lights (tbh I already did that a week ago but forgot to mention it)


I tested the aura against Strife's Programmer and all Heretic episode bosses and their scripted deaths work fine now. I assume it works against Korax as well.

Added