[Submission] MechPlasmaDemon

info:
Name: CyberPlasmaDemon
Difficulty: Medium
Connection: PlasmaDemon
Summon: mechplasmademon, mechpld
Melee: yes
Distance: yes, a orange ball from plasma demon but it deals more damage
Type: Demon/Cybernetic
credits
Submitted: herif6677
Decorate: herif6677
GLDEFs: N/A
Sounds: idsoftware
Sprites: id Software
Sprite Edit: Warhawk
idea base: we need stronger plasmademon.
Description:
stronger version of plasma demon he's fast hard to kill throws more plasma ball eats you faster
sprite:

download:https://drive.google.com/file/d/1jnlr0eKdN9yk0jz9spR_e5RQQH9QXaf0/view  

The submission should be repackaged and put in a PK3 archive instead of a WAD. I would also suggest giving the actor editor keys  and maybe a number too, and optimizing the sprites .

Besides that, the spelling, grammar, and code indentation are absolutely all over the place. Random letters are capitalized, most function calls are capitalized except for the A_CustomMissile ones, some lines of code are indented at all while most of them are not, properties and flags have random capitalization. The grammar on the obituaries is wrong (e.g "The MechPlasmaDemon Gived nice Orange to %o", should be more like "The Plasma Demon gave a nice orange to %o"). There also seems to be a random strangely named variant of the demon that is mostly translucent.

Here's what the code should look more like, using the actor definition up to the Melee state sequence as an example, and should be intended by making spaces in SLADE using the TAB key instead of spacebar:

Besides these glaring code issues there's more minor ones, like how the function calls use their flag parameters using the direct integer value of all the flags put together for some reason, instead of using the flag names, which unnecessarily obfuscates the code. Like how the A_CustomMissile calls just have the number 1 as their flag parameter, instead of using CMF_AIMOFFSET, which is the name of the flag that the number 1 represents. A_SpawnItemEx also uses the number 128 for its' flag parameter, but I have no idea what those flags are altogether, because the enum for A_SpawnItemEx's flags uses bit shift operators instead of normal integers/numbers .

All the code issues aside, the NPC is also just very unbalanced, it has 535 health, a bit higher than the Hell Knight, compared to the original Plasma Demon which only had 50 more health than the vanilla Pinky, so since this is meant to be a more powerful Plasma Demon, 250 would be a more fitting and fair amount of health. Also making them always drop a full cell pack and plasma rifle is a bit too generous, making them semi-frequently drop a small cell charge, semi-rarely drop a full charge, and only rarely (If at all.) drop a plasma rifle would be better, you can change the chances of DropItem dropping an item and how much of it will be dropped to do that in case you don't know .

thanks for these stuff i will change it later

also strange named variant is spectre one

I figured so, but you should rename it to something more descriptive of what it is than just "mechpld".

Its really very good stuff!!

Now that's awesome. Has this been reworked for distribution yet? Wouldn't mind adding this dude 
to my Megawad.

Any updates on this submission ? If there's no new sign of activity from the author by about a week from now. I'll probably be closing this submission due to inactivity.

This one is cool I like it. Would be a shame to see it closed.

CaptainToenail wrote:

This one is cool I like it. Would be a shame to see it closed.

Well, Herif hasn't been online for almost 5 months as of now. So it seems unlikely that there will be an update to this submission. I could always just submit it myself or something though. I just got the .wad too, in case the download link ever goes down.