[Help] Low health fade/blood splatter effect
- CaptainManiac
-
Topic Author
- Cacodemon
-
- CaptainManiac
-
Topic Author
- Cacodemon
-
- MagicWazard
-
- Moderator
-
- BadMojo
-
- Wicked
-
8 years 1 month ago - 8 years 1 month ago #4
by BadMojo
Replied by BadMojo on topic My childish questioning again....
We all make mistakes, its how we learn 
But anyway, Ive messed around with your script and noticed a few things.
Here is what Ive done:
I kind of just rewritten the whole thing, theres a few things missing from the one you posted but you can add them in later.
Firstly, for the intensity value in FadeTo, it should be a float otherwise it wont work, that was the main issue.
The second thing that wasnt working was the TID for GetActorProperty. Basically you just need to assign the player thing to a TID, so Ive set it so that player 1's TID is 1000, player 2'2 TID is 1001 etc...
Then to simplify the whole thing, I just created an int called P_Health to contain the value of APROP_Health... It just makes everything neat and tidy.
I removed all of the delays and just set a 1 tick delay right at the end before the loop.
Oh and lastly, I started the script with ENTER not OPEN, so that it start when the player enters the map rather than when the map starts.
But anyway, Ive messed around with your script and noticed a few things.
Here is what Ive done:
Code:
#include "zcommon.acs"
script 1 ENTER
{
Thing_ChangeTID(0, 1000 + PlayerNumber()); //Assign the player a TID
int P_Health = GetActorProperty(1000, APROP_HEALTH); /*A variable containing the value of APROP_HEALTH
(it just simplifies the code and makes it easier to read))*/
if(P_Health >= 51) /* This is so the game knows what to do at more than 50 health,
without this, it will fade as if its 50 health the moment the script runs.. its also good to have a default point for over 50 hp*/
{
FadeTo(0,0,0,0.0,1.0); //Changed the intensity value to a floating point, and gave it a 1 second fade time
}
else if(P_Health <= 50)
{
FadeTo(128,128,128,0.5,1.0);
}
else if(P_Health <= 40)
{
FadeTo(128,128,128,0.6,0.0);
}
else if(P_Health <= 30)
{
FadeTo(255,0,0,0.7,0.0);
}
else if(P_Health <= 10)
{
FadeTo(255,0,0,0.8,0.0);
}
else if(P_Health <= 1)
{
FadeTo(255,0,0,0.9,0.0);
}
delay(1);
restart;
}
I kind of just rewritten the whole thing, theres a few things missing from the one you posted but you can add them in later.
Firstly, for the intensity value in FadeTo, it should be a float otherwise it wont work, that was the main issue.
The second thing that wasnt working was the TID for GetActorProperty. Basically you just need to assign the player thing to a TID, so Ive set it so that player 1's TID is 1000, player 2'2 TID is 1001 etc...
Then to simplify the whole thing, I just created an int called P_Health to contain the value of APROP_Health... It just makes everything neat and tidy.
I removed all of the delays and just set a 1 tick delay right at the end before the loop.
Oh and lastly, I started the script with ENTER not OPEN, so that it start when the player enters the map rather than when the map starts.
Last edit: 8 years 1 month ago by BadMojo.
Please Log in or Create an account to join the conversation.
- CaptainManiac
-
Topic Author
- Cacodemon
-
- CaptainManiac
-
Topic Author
- Cacodemon
-
- BadMojo
-
- Wicked
-
8 years 1 month ago - 8 years 1 month ago #7
by BadMojo
Replied by BadMojo on topic My childish questioning again....
Can you provide me a sample of the code you wrote?
Ill see what I can do from what I sent you already in terms of displaying an image on the screen... Whilst playing with the code you sent earlier though, I noticed there was the letter 'a' in the middle of the crosshair, so that worked at least.. But Ill mess around with it anyway and see what I can do to help
Ill see what I can do from what I sent you already in terms of displaying an image on the screen... Whilst playing with the code you sent earlier though, I noticed there was the letter 'a' in the middle of the crosshair, so that worked at least.. But Ill mess around with it anyway and see what I can do to help
Last edit: 8 years 1 month ago by BadMojo.
Please Log in or Create an account to join the conversation.
- CaptainManiac
-
Topic Author
- Cacodemon
-
- BadMojo
-
- Wicked
-
8 years 1 month ago #9
by BadMojo
Replied by BadMojo on topic My childish questioning again....
After looking at your old code, theres a problem with the way your setting the fixed X and Y positions of the in conjunction with the SetHudSize. Try this line instead of the one you have already:
It should place the 1024x1024 image you have in the center of the screen... if you cant see the image still, its probably because the way you have that image nested in, what I'm assuming is your WAD?.. It doesnt work if its between the F_START and END lumps, I can only assume it wont work between the sprite and the other lumps that tell the game what type of image it is.. so just have it outside of any of those and you should be right. If your using a pk3, then the graphics folder should be fine.
The other problem that I noticed, is that so long as your health is 40 or below, it will keep the image on screen until health goes above 40 again.. rather than fade it out after the 3.7 seconds, like the way you have it set to in your first post.. Im not sure if this is intentional or not but to remedy that, it might be a good idea to set a couple of int's or bool's, to check in an if statement, when health has gone below 40 and when it goes back up again, so that it doesnt constantly loop the HudMessage image, and just does it once and fades it out... If that makes any sense at all
Edit: Heh, I was in the process of typing all of that above in an edited post.... but you replied in the process so I didnt see it until now... but anyway it should still apply to the code you have now
Code:
HudMessageBold(s:"A"; HUDMSG_FADEINOUT, 0, CR_WHITE, 0.5, -0.5, 3.7);
It should place the 1024x1024 image you have in the center of the screen... if you cant see the image still, its probably because the way you have that image nested in, what I'm assuming is your WAD?.. It doesnt work if its between the F_START and END lumps, I can only assume it wont work between the sprite and the other lumps that tell the game what type of image it is.. so just have it outside of any of those and you should be right. If your using a pk3, then the graphics folder should be fine.
The other problem that I noticed, is that so long as your health is 40 or below, it will keep the image on screen until health goes above 40 again.. rather than fade it out after the 3.7 seconds, like the way you have it set to in your first post.. Im not sure if this is intentional or not but to remedy that, it might be a good idea to set a couple of int's or bool's, to check in an if statement, when health has gone below 40 and when it goes back up again, so that it doesnt constantly loop the HudMessage image, and just does it once and fades it out... If that makes any sense at all
Edit: Heh, I was in the process of typing all of that above in an edited post.... but you replied in the process so I didnt see it until now... but anyway it should still apply to the code you have now
Please Log in or Create an account to join the conversation.
- BadMojo
-
- Wicked
-